-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): Add repeatWhen operator #1911
Conversation
@@ -287,6 +287,7 @@ children: | |||
- label: I want to re-subscribe | |||
children: | |||
- label: repeat | |||
- label: repeatWhen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify how this file works, you have to add a description label before adding children:
> - label: repeatWhen
as the child of the description label. Just check how all other operators are formatted in this file. Not repeatWhen
right under repeat
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed
* @ignore | ||
* @extends {Ignored} | ||
*/ | ||
class RetryWhenSubscriber<T, R> extends OuterSubscriber<T, R> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RetryWhenSubscriber
-> RepeatWhenSubscriber
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done.
LGTM, needs rebase. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
It still has four test from retryWhen, that are disabled as they don't make sense for repeatWhen. Maybe there are some alternative tests that should be included instead.
Related issue (if exists):